Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Material3 attribution button to an attribution bar visible by default #174

Open
sargunv opened this issue Dec 24, 2024 · 2 comments · May be fixed by #248
Open

Change Material3 attribution button to an attribution bar visible by default #174

sargunv opened this issue Dec 24, 2024 · 2 comments · May be fixed by #248
Labels
enhancement New feature or change to an existing feature
Milestone

Comments

@sargunv
Copy link
Owner

sargunv commented Dec 24, 2024

See discussion in maplibre/maplibre-native#2600

probably depends on #164

@sargunv sargunv added the enhancement New feature or change to an existing feature label Dec 24, 2024
@sargunv sargunv modified the milestone: v0.5.0 Dec 25, 2024
@sargunv sargunv added this to the v0.6.0 milestone Dec 31, 2024
@westnordost
Copy link
Collaborator

westnordost commented Jan 3, 2025

On web it is usually no issue to display all attribution in one line. Still, the list of necessary attribution can in some cases be very long. If that attribution bar/button is also used on small screens, something should be done if it doesn't fit. I'd propose this:

imagen

  1. Show the info button as a round button (i.e. like the compass button but smaller), aligned to the end side, not smaller than the attribution text height or ideally actually the same height.
  2. Like on web, from the button a rounded bar extends towards the start side with the attribution text on it. If the text length exceeds the available space, an "…" is shown at the end.
  3. When the map is interacted (after a certain minimum delay?), the bar quickly slides into the info button. Maybe the info button could have an unobtrusive animation that helps with the metaphor that it slid "into" the button, e.g. a short scale up, scale back down springy.
  4. On info button press, the bar doesn't slide back out, instead, the attribution dialog is shown.

@westnordost
Copy link
Collaborator

All OpenStreetMap contributors will be thankful for a change that makes the attribution better visible by default. Thumbs up for that!

@westnordost westnordost linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or change to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants