-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The camera follow demo does not stop following on compass ornament or double tap zoom #77
Comments
material compass part fixed in #179 double tap and SDK compass is still outstanding |
I noticed that when the camera follow animation is run, the move reason is programmatic, but when it's not, the move reason is a gesture. It may be because of the execution of I'm not sure if it's important, but I also noticed that when the camera follow animation is run and I tap on the map without moving it, it detects it as a programmatic camera movement (double tap, detects 2 programmatic camera movements), but when I tap on the map when there is no animation, it doesn't detect any camera movement. As for differentiation between the developer's and API's programmatic reasons for camera movement, it seems to be a bug in Maplibre, and it was an issue before the fork on Mapbox (see: mapbox/mapbox-gl-native#10674 (comment)) As a workaround for the demo, we can stop the animation on zoom changes, but it's not a real solution, so probably not a good option. |
Yup. We're limited by what the SDK provide here. Calling animateTo so frequently doesn't even work properly on JS. I'm hoping to solve this by moving the gestures implementation fully into this library. We'll need to reimplement gestures anyway for desktop native, so if we make that common code I hope we can solve this and also get better integration with Compose gesture interop APIs. |
Since #76 the camera follow demo stops following when any gesture happens, but the double tap zoom gesture doesn't trigger this. Neither does the compass. It seems both are considered "programmatic" rather than gestures? Would be useful to differentiate between built in programmatic and public API programmatic.
Affects both Android and iOS.
The text was updated successfully, but these errors were encountered: