Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Log4j2 migration #1082

Open
m273d15 opened this issue Sep 11, 2020 · 1 comment
Open

Complete Log4j2 migration #1082

m273d15 opened this issue Sep 11, 2020 · 1 comment
Labels
Area: Core Issue affecting the Saros Core Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I) Area: Server Issue affecting the Saros Server Area: VSCode Issue affecting Saros for VSCode (Saros/VSC)

Comments

@m273d15
Copy link
Contributor

m273d15 commented Sep 11, 2020

With #270/#1064 we migrated the Log4j backend to Log4j2.
Only the framework set-up and initialization had to be migrated
in this step. However, we still use the old API (of log4j) instead
of the log4j2 API.
Migrating the API leads to changes in a myriad of files. Therefore,
we should automate as much as possible.

You can find further information in the logging docs.

@m273d15 m273d15 added Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I) Area: Core Issue affecting the Saros Core Area: Server Issue affecting the Saros Server Area: VSCode Issue affecting Saros for VSCode (Saros/VSC) labels Sep 11, 2020
@m273d15
Copy link
Contributor Author

m273d15 commented Sep 16, 2020

I wrote a small migration script (Disclaimer: This script uses heuristics and the output should be validated). It should migrate all relevant calls, but manual changes are required if:

  • A function call is migrated to a closure, but an object is not accessible in the closure context.
  • A method is still wrapped in an ifTraceEnabled if-block.

I would recommend avoiding a big bang migration and use the script to migrate packages or components (e.g. core) step-by-step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Issue affecting the Saros Core Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I) Area: Server Issue affecting the Saros Server Area: VSCode Issue affecting Saros for VSCode (Saros/VSC)
Projects
None yet
Development

No branches or pull requests

1 participant