Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CocoaPods test cases #24

Closed
11 tasks done
uranusjr opened this issue Feb 2, 2020 · 4 comments
Closed
11 tasks done

Fix CocoaPods test cases #24

uranusjr opened this issue Feb 2, 2020 · 4 comments

Comments

@uranusjr
Copy link
Member

uranusjr commented Feb 2, 2020

Follow up of #21.

  • complex_conflict.json
  • shared_parent_dependency_with_swapping.json
  • spapping_and_rewinding.json
  • circular.json
  • complex_conflict_unwinding.json
  • conflict_on_child.json
  • deep_complex_conflict.json
  • fixed_circular.json
  • previous_conflict.json
  • pruned_unresolved_orphan.json
  • swapping_children_with_successors.json
@uranusjr
Copy link
Member Author

uranusjr commented Feb 3, 2020

Two discrepancies (circular and fixed_circular) are actually design decision differences. These are tracked in #25 to decide whether we want to offer the possibility of cycle detection.

The remaining three failures (complex_conflict, shared_parent_dependency_with_swapping, spapping_and_rewinding) are all due to ResolutionTooDeep. I tried increase the threshold (from 100 to 10000) without success. Will need to dive into them to know what’s actually going on (it’s just too complex, or if the resolver is stalling).

Interestingly not all “complex” fixtures fail, and two of the failed fixtures don’t seem that complex to me (shared_parent_dependency_with_swapping is quite unwieldy though).

@uranusjr
Copy link
Member Author

uranusjr commented Feb 3, 2020

complex_conflict_unwinding also fails if I use Molinilo’s visiting order (i.e. implement get_preference the other way around). So maybe these complex fixtures are indeed complex for Molinilo?

@uranusjr
Copy link
Member Author

uranusjr commented Feb 3, 2020

Fixed the stalling in 12c5d6a! Just one to go… complex_conflict.

@uranusjr
Copy link
Member Author

uranusjr commented Feb 3, 2020

Caught! fe8f0dc

@uranusjr uranusjr closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant