Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification of upcoming breaking change in go-gh config package #62

Closed
williammartin opened this issue Oct 24, 2023 · 0 comments · Fixed by #63
Closed

Notification of upcoming breaking change in go-gh config package #62

williammartin opened this issue Oct 24, 2023 · 0 comments · Fixed by #63
Assignees

Comments

@williammartin
Copy link

Hello gh extension author!

We noticed that you are making use of the config package from go-gh. While this package is documented as for internal use only, we understand that sometimes extension authors do so at their own risk. While we don’t provide support for this right now, we do want to make you aware of a breaking change when you pull in the next version so that you aren’t caught by surprise.

Oh no! What do you need to do?

Fortunately the change is minor, we changed the Read function signature to accept a fallback *Config if no persisted configuration is found. This means that you will need to now provide nil in each location you call config.Read.

From looking at your source code, we don’t believe there should be any other impact at compile or run time.

Cheers,

The CLI team.

@sarumaj sarumaj self-assigned this Oct 24, 2023
@sarumaj sarumaj linked a pull request Oct 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants