Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 tag out-of-date #215

Open
Dreamsorcerer opened this issue Feb 2, 2023 · 1 comment
Open

v1 tag out-of-date #215

Dreamsorcerer opened this issue Feb 2, 2023 · 1 comment

Comments

@Dreamsorcerer
Copy link

Dreamsorcerer commented Feb 2, 2023

I was going to create an issue because my CI passes despite mypy failing with:

.mypy.ini:16: error: Error importing plugin "sqlalchemy.ext.mypy.plugin": The SQLAlchemy mypy plugin in SQLAlchemy 2.0 does not work with sqlalchemy-stubs or sqlalchemy2-stubs installed, as well as with any other third party SQLAlchemy stubs.  Please uninstall all SQLAlchemy stubs packages.  [misc]
Found 1 error in 1 file (errors prevented further checking)

However, I'm not sure if it's a problem with the latest release or not, as I was using v1, which does not appear to point to the latest release.

Convention for actions is that a v1 tag is kept up-to-date with the latest v1.x release. So, I'd suggest deleting that tag and renaming it to v1.0 if you don't plan move it to the latest release. That should avoid any confusion.

@sasanquaneuf
Copy link
Owner

Thank you for your comment. I deleted the v1 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants