Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass_import_get_base() different results when using data vs file compiler #1041

Closed
drewwells opened this issue Apr 3, 2015 · 1 comment
Closed
Labels
Milestone

Comments

@drewwells
Copy link
Contributor

As noted here: #1035 (comment) these two functions have different results based on the compiler in use.

File compiler returns absolute paths, while data compiler returns relative paths for base and previous_path. Pardon my pseudo code

testfile.scss

@import "sub/deeptest";

DataCompiler

path:         testfile
prev.path:  stdin
prev.base: stdin
testfile.scss
path:          sub/deeptest
prev.path:  testfile
prev.base: testfile.scss

FileCompiler (targeted testfile directly, so only one result)

path: sub/deeptest
prev.path: testfile.scss
prev.base: /project/sass/testfile.scss

Even though both compilers negotiated the correct absolute path, data compiler only returned the relative path. IMO, these should both return absolute path for base. Thoughts?

@mgreter mgreter added this to the 3.2.1 milestone Apr 8, 2015
@mgreter mgreter added the C API label Apr 8, 2015
@xzyfer xzyfer modified the milestones: 3.2.2, 3.3 May 1, 2015
@mgreter mgreter modified the milestones: 3.4, 3.3 Jun 13, 2015
@mgreter
Copy link
Contributor

mgreter commented Sep 3, 2015

The function sass_import_get_base has been renamed to sass_import_get_abs_path. I also fixed quite a few issues with how we report included files. Since so much has changed between this report and current master, I'm going to close this now. But please feel free to re-open or preverably open a new bug if you find any other problems! Thanks!

@mgreter mgreter closed this as completed Sep 3, 2015
@mgreter mgreter removed this from the 3.4 milestone Sep 3, 2015
@xzyfer xzyfer added this to the 3.3 milestone Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants