-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SourceMaps lines offset for interpolated selectors #2224
Comments
Thanks for the thorough bug report. I can see the issue clearly in the sourcemap inspector. I suspect the error to stem from reparsing the interpolated selectors on the eval stage (unconfirmed). |
@rodneyrehm can you tell on which versions you saw this error. Wondering if it got introduced with some latest sourcemap changes in 3.4-RC1. I specially would like to know if 3.3.6 already had this issue!? Thx! |
I have updated my sourcemap inspector to PR #2268. @nschonni can you check it to see if #2268 fixes the most urgent issue. As laid out in said PR, the mappings for the selector schema parts are still garbage, but at least to following mappings should no longer be off! |
I have merged #2268. It should fix the most urgent problems here! |
The SourceMaps generation seems to trip over multi-line selectors if they contain interpolations (
#{$variable}
). In the demo SCSS below the generated CSS.zulu-delta
is referenced to line 17, while it should be line 19. This does not happen for non-interpolated multi-line selectors. A single interpolation in the selector string causes the lines to collapse before the mutation could be tracked in SourceMaps. The offset is not recovered from, so all SCSS content after such an interpolated selector is affected by the shift in line number.input.scss (SourceMap)
version info:
The text was updated successfully, but these errors were encountered: