ctx->includedFiles misleading stdin

[am11]

Consider the following structure:

c:/temp/alpha/index.scss

@import 'foo.scss';
@import 'bar.scss';

c:/temp/alpha/foo.scss

body {
  color: red;
}

c:/temp/alpha/bar.scss

p {
  color: grey;
}

With node-sass, if you do:

//# while you are in node-sass directory, enter node-interactive-console by typing
$ node
>
var stats = {};
require("./lib/").render({
   data: fs.readFileSync('c:/temp/alpha/index.scss','utf8'),
   stats: stats,
   includePaths: ['c:/temp/alpha']
});

console.log(stats);

It gives:

> { entry: 'data',
  start: 1415551465290,
  includedFiles: [ 'c:/temp/alpha/foo.scss', 'stdin' ],
  end: 1415551465325,
  duration: 35,
  sourceMap: undefined 

in stats. The expected behavior is to have includedFiles: ['c:/temp/alpha/foo.scss', 'c:/temp/alpha/bar.scss'] instead of stdin. Since this is data input, otherwise it would also contain reference to index.scss, had it be the file input (which it produces correctly with require("./lib/").renderSync({file: 'c:/temp/alpha/index.scss', ..).

/cc @mgreter (I tested with your branch: api/c-interface, but still the same issue)

[mgreter]

ACK, it probably shouldn't be on that array. Sorry, I was not really passing included_files back till lately in perl-libsass, therefore I haven't had any unit tests for this! Unfortunately the array gets sorted before returning, therefore you'll get stdin on that position. Since it is only a status array and not used internally it should be trivial to add a check before adding it to the array (also because the other paths are absolute, which means "stdin" is not a valid path for any other file).

On another issue, I have removed num_included_files in favor of using a null terminated "array". But sass_interface is still using it. I probably just have to copy the updated code from the new sass_context to fix this!

[am11]

Thanks @mgreter! 👍

So basically, from the above example, bar.scss is there in the returned array but num_included_files is returning wrong count? This only happens in case of data input.

[mgreter]

Was a bit more complex! Aded some more info to this commit message!

[am11]

Awesome! 😄 👍

[mgreter]

This should be fixed by 9b984fa

[am11]

Indeed this is fixed. 😃 👍