Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Segfault calling simple-selectors() #1880

Closed
chriseppstein opened this issue Feb 2, 2017 · 6 comments
Closed

Segfault calling simple-selectors() #1880

chriseppstein opened this issue Feb 2, 2017 · 6 comments

Comments

@chriseppstein
Copy link
Contributor

simple-selectors('&:hover') causes a segfault.

In ruby Sass it gives an error:

Error: $selector: "&:hover" is not a valid selector: Invalid CSS after "": expected selector, was "&:hover" for `simple-selectors'
        on line 1 of standard input
@xzyfer
Copy link
Contributor

xzyfer commented Feb 2, 2017

Which version of node-sass?
Which architecture?

@xzyfer
Copy link
Contributor

xzyfer commented Feb 2, 2017

We're having some weird environment specific segfaults after the recent memory manager changes in LibSass.

@chriseppstein
Copy link
Contributor Author

$ node-sass -v
node-sass	4.5.0	(Wrapper)	[JavaScript]
libsass  	3.5.0.beta.2	(Sass Compiler)	[C/C++]
$  uname -a
Darwin ceppstei-mn1 15.6.0 Darwin Kernel Version 15.6.0: Mon Jan  9 23:07:29 PST 2017; root:xnu-3248.60.11.2.1~1/RELEASE_X86_64 x86_64

@mgreter
Copy link
Contributor

mgreter commented Feb 4, 2017

@xzyfer IMO so far we haven't had one real issue with the memory manager changes. This one is simply a null pointer access leading to a segfault. Fixed in sass/libsass#2318.

@xzyfer
Copy link
Contributor

xzyfer commented Feb 6, 2017

@mgreter as far as I can tell #1879 is related to the memory manager changes.

@xzyfer xzyfer mentioned this issue Feb 20, 2017
@nschonni nschonni added this to the 4.6 milestone Apr 24, 2017
@saper saper modified the milestones: 4.6, libsass-3.4.6 Nov 12, 2017
@xzyfer
Copy link
Contributor

xzyfer commented Mar 10, 2018

Fixed in 4.8.0

@xzyfer xzyfer closed this as completed Mar 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants