-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Consider adding support for sourcesContent to the source map #363
Comments
I've looked into handling this ourselves, but the problem is that the entries in the |
Hm, just to chime in here... I wonder if this issue is best raised on upstream libsass repo itself? |
@joliss I think you're right, libsass does all the work, node-sass just wraps it in a javascript interface. It looks like there's an open issue over here: sass/libsass#212 |
Oh yeah, good point @joliss! I'll do that... |
The feature seems to already be implemented in libsass sass/sass@dd48bb9. Am I missing something? |
Yes, this is supported by libsass now. Has this option been exposed via node-sass yet? |
@aexmachina, ICYMI: #543. 😄 |
Great, thanks @am11. That looks really good, looking forward to a cleaner API! |
Hey @aexmachina, totally forgot about this one. The good news is: v2 is out with this feature. See changelog https://github.com/sass/node-sass/releases/tag/v2.0.0-beta and README. |
The source map spec supports embedding the content of the source files into the source map. This provides a good solution for source maps that "just work", without requiring the user to ensure that the source files are available over HTTP or using user-agent specific features such as Chrome's Workspaces feature.
A suggestion would be to provide an option
.includeSources
to indicate that the sources should be included in the source map. I'd submit a PR but it's coming from the C code, so I'm not the man for the job.The text was updated successfully, but these errors were encountered: