Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding Ruby dependency choice #90

Open
am11 opened this issue Dec 31, 2014 · 2 comments
Open

Regarding Ruby dependency choice #90

am11 opened this issue Dec 31, 2014 · 2 comments

Comments

@am11
Copy link
Contributor

am11 commented Dec 31, 2014

@mgreter, @xzyfer

Here is a list of C++ testing frameworks: http://en.wikipedia.org/wiki/List_of_unit_testing_frameworks#C.2B.2B

I purpose to make use of one of these (for instance CppUnit) to run sass-spec test suite in an effort to exempt
ruby dependenc[y/ies] (gem install minitest et al.).

One of the chief benefit is that it would enable us to test libsass' disableable options
more thoroughly and especially those related to source-map.

Thoughts?

BTW, Happy new year 2015! 🎈 🎉 🎆

@am11
Copy link
Contributor Author

am11 commented Jan 1, 2015

Note: in node-sass, we clone the spec repo, filter the tests and then loop through the suite to run each as a regular node.js test (using mocha f/w): spec.js#L29-L56. We can achieve the same here using CppUnit.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 2, 2015

My thoughts from gitter conversation

- I'm all for dumping ruby where ever possible
- But sass-spec also does a little more than just run tests
- It has a couple utilities that we use to discover when previously failing start passing unexpectedly, and to normalise our expected outputs in specs
- It's not to say we couldn't do these things in CPP I'm just not sure it's worth the time to build those features
Maybe we could keep the ruby runner and have it shell out to cppunit instead of minitest as a way to get those features
- We also want sass-spec to become the defacto for all sass implementations, including ruby sass. So it coupling it too tightly to libsass will be problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants