Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude code block with comments #600

Closed
ncoden opened this issue Apr 7, 2016 · 1 comment
Closed

Exclude code block with comments #600

ncoden opened this issue Apr 7, 2016 · 1 comment

Comments

@ncoden
Copy link
Contributor

ncoden commented Apr 7, 2016

I think it can be usefull to exclude a block code for one or all rules with comments. Sometimes I want to bypass a rule for browser compatibility reasons, but without disabling this rule for the whole project.

We can do like eslint :

// Disable one or all rules on a whole selector or property group

// sass-lint-disable {rule name}
.foo { ... }
// sass-lint-enable {rule name}
// Disable one or all rules on a single property

.foo {
  property: value;
  property: value; // sass-lint-disable {rule name}
  property: value; // sass-lint-ignore {rule name}
}

But personally I don't like to see sass-lint inside by code. I prefer something like (we can purpose both).

.foo {
  property: value;
  property: value; // hack
  property: value; // !hack
}

What do you think ?

@BPScott
Copy link

BPScott commented Apr 7, 2016

This is a duplicate of issue #70 and work is already in progress in PR #402.

@DanPurdy DanPurdy closed this as completed Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants