Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS - Parser breaks on nested child selectors #643

Closed
colin-marshall opened this issue Apr 23, 2016 · 4 comments
Closed

SCSS - Parser breaks on nested child selectors #643

colin-marshall opened this issue Apr 23, 2016 · 4 comments

Comments

@colin-marshall
Copy link

Hey guys, thanks for the awesome work getting 1.6 out! I just tested it out with Foundation and noticed a lot of the files that were throwing fatal errors are now getting linted (yay!), but there's still a couple fatal errors being thrown in a few files. It looks like there are two issues causing six files to fail.

This error is an issue with the AST (tonyganch/gonzales-pe#130), but since you're using a fork and there is a PR open that resolves this issue (tonyganch/gonzales-pe#157), I figured it was worth bringing up here.

These are the breaking lines:
https://github.com/zurb/foundation-sites/blob/develop/scss/components/_dropdown-menu.scss#L68
https://github.com/zurb/foundation-sites/blob/develop/scss/components/_menu.scss#L59
https://github.com/zurb/foundation-sites/blob/develop/scss/components/_tabs.scss#L127

@bgriffith
Copy link
Member

Thanks for the report. We'll look at getting the fix in the fork 👍

@DanPurdy
Copy link
Member

This shouldn't have been closed.. Still seems to break

@DanPurdy DanPurdy reopened this Apr 27, 2016
@colin-marshall
Copy link
Author

@DanPurdy the breaking lines referenced in OP are no longer breaking with v1.7.0.

@DanPurdy
Copy link
Member

@colin-marshall great news! I must of been having a moment when i tested this earlier on..

I'll close this for now then, glad it's working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants