Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False-positive warning around shorthand-values #669

Closed
zslabs opened this issue May 3, 2016 · 2 comments · Fixed by #673
Closed

False-positive warning around shorthand-values #669

zslabs opened this issue May 3, 2016 · 2 comments · Fixed by #673
Labels

Comments

@zslabs
Copy link

zslabs commented May 3, 2016

Hi,
I have the following block:

margin: calc(#{$doc-header-height} + #{$global-whitespace--regular}) 0 $global-whitespace--regular 0;

This throwing the following error:

warning  Property `margin` should be written more concisely as ` 0 $global-whitespace--regular` instead of ` 0 $global-whitespace--regular 0`  shorthand-values

I have verified that the end-result of the calc() is: margin: 76px 0 16px;. Are you able to duplicate the same/ Thanks!

@DanPurdy
Copy link
Member

DanPurdy commented May 4, 2016

Hi @zslabs

Thanks for reporting this, I've managed to recreate and also produced a fix in #673 It seemed we were not correctly looking at functions being used as values in condensable properties and also due to the AST changes recently we weren't looking at interpolated values either (as the AST failed on them previously!).

@zslabs
Copy link
Author

zslabs commented May 4, 2016

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants