Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup web clients on disconnect #11

Closed
satoshinm opened this issue Apr 13, 2017 · 2 comments
Closed

Cleanup web clients on disconnect #11

satoshinm opened this issue Apr 13, 2017 · 2 comments
Labels
bug

Comments

@satoshinm
Copy link
Owner

Remove the entity and notify other web clients it deleted (D command), remove from maps

problem: how to detect when a websocket disconnects in netty? (there is a regular heartbeat/ping I believe)
@satoshinm satoshinm added the bug label Apr 13, 2017
@satoshinm
Copy link
Owner Author

public void userEventTriggered(final ChannelHandlerContext ctx, Object evt) throws Exception { is not called when the channel closes, but public void channelInactive(ChannelHandlerContext ctx) { is, documented in http://netty.io/4.0/api/io/netty/channel/ChannelInboundHandler.html#channelInactive-io.netty.channel.ChannelHandlerContext-

@satoshinm
Copy link
Owner Author

Implemented, but note Glowstone bug: GlowstoneMC/Glowstone#453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@satoshinm