Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not getting errors when requesting products #41

Open
dvkch opened this issue Oct 25, 2016 · 1 comment
Open

Not getting errors when requesting products #41

dvkch opened this issue Oct 25, 2016 · 1 comment

Comments

@dvkch
Copy link

dvkch commented Oct 25, 2016

Hi,

I just noticed when -requestProductsWithCompletion: doesn't report errors happening in the request. Adding a NSError * parameter to the block type and the following method to IAPHelper.m seems to fix the issue for me :

- (void)request:(SKRequest *)request didFailWithError:(NSError *)error
{
    self.request = nil;

    if(_requestProductsBlock) {
        _requestProductsBlock (request,nil, error);
    }
}

Do you confirm it is the right approach and if so would it be possible to add it to a future release ?

Thanks a lot for considering,

Stan

@dvkch
Copy link
Author

dvkch commented Oct 25, 2016

Noticed it was reported as #21 . I can reproduce it on iOS 8.4.1 and iOS 10.0.2 just by calling this single method and having no internet connectivity (iPhone on Airplane mode or iPad with Wi-Fi off)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant