Added boolean/integer return types to delete*() methods #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added boolean return for single-deletion operations.
Simplified "deleteAll(Class<T>)" method. Created tests for boolean and integer return type of delete methods.
|
Ok, just realized that the coverage is even lower than before, I´m just creating more tests right now ;) |
| @@ -85,6 +86,7 @@ | |||
| sqLiteDatabase.endTransaction(); | |||
| sqLiteDatabase.setLockingEnabled(true); | |||
| } | |||
| return deletedRows; | |||
There was a problem hiding this comment.
This return a non zero number if the transaction is aborted while it's occurring. However, since it's a transaction, it'll roll back all of the deletes, so you should be returning zero in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added also tests.
Update of #297
@whoshuu Here we go!