Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note mentioning IIS.Compression #2

Closed
matbech opened this issue Feb 13, 2019 · 4 comments
Closed

Add note mentioning IIS.Compression #2

matbech opened this issue Feb 13, 2019 · 4 comments

Comments

@matbech
Copy link

matbech commented Feb 13, 2019

You may want to add a note that Microsoft has released a new module now which also supports Brotli:
https://github.com/Microsoft/IIS.Compression

@saucecontrol
Copy link
Owner

Oh wow, I didn't know they finally made one. Since that one doesn't have the MSVC intrinsics change I added to mine, it will be slower. It's also interesting that they're using stock zlib rather than the faster Intel updated version included in .NET Core.

I'll see what I can do about getting those improvements added to the official one.

@matbech
Copy link
Author

matbech commented Feb 13, 2019

The zlib Intel version is broken and I'm not sure if the issue was fixed in the meanwhile:
intel/zlib#21

I do appreciate your efforts to get the MSVC intrinsics into the brotli upstream:
google/brotli#636

@saucecontrol
Copy link
Owner

Do you have any more info on that zlib issue? Microsoft is using that version in current builds of .NET Core, so it would be good to know if that's a reproducible problem.

@saucecontrol
Copy link
Owner

Finally got around to updating the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants