Regression with custom color scheme in 3.1.1

[daviewales]

Small description

I use a Terminal colour scheme based on Gruvbox Material Hard Dark.
In the past, (pre 3.1.1), Visidata has worked perfectly with it.
Since 3.1.1, there are a few issues.

Data to reproduce

My colour scheme settings:

        {
            "background": "#1D2021",
            "black": "#665C54",
            "blue": "#7DAEA3",
            "brightBlack": "#FFE5CB",
            "brightBlue": "#B7FFEF",
            "brightCyan": "#C2FFB8",
            "brightGreen": "#EDFF8E",
            "brightPurple": "#FFA2BB",
            "brightRed": "#FF726B",
            "brightWhite": "#82745D",
            "brightYellow": "#FFC467",
            "cursorColor": "#FFFFFF",
            "cyan": "#89B482",
            "foreground": "#D4BE98",
            "green": "#A9B665",
            "name": "Gruvbox-Material Hard Dark",
            "purple": "#D3869B",
            "red": "#EA6962",
            "selectionBackground": "#FFFFFF",
            "white": "#D4BE98",
            "yellow": "#D8A657"
        },

Visidata before and after:

The issue seems to be that the defaults are now x on black for most colour options.
However, if I update these to x on background, everything looks nice again.

Should the Visidata defaults use background rather than black for the backgrounds?

Or is this operating as intended, and I should just update my visidatarc?

Additional context

• What platform and version are you using (Linux, MacOS, Windows)? Windows 11

• Which version of Python? 3.10.12

• Which terminal are you using (for display and input issues)? WSL in Windows Terminal