Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider sqlite with sqlcipher backend #430

Open
tmpfs opened this issue May 25, 2024 · 2 comments
Open

Consider sqlite with sqlcipher backend #430

tmpfs opened this issue May 25, 2024 · 2 comments
Assignees

Comments

@tmpfs
Copy link
Collaborator

tmpfs commented May 25, 2024

https://www.zetetic.net/sqlcipher/design/

This is what Signal uses interestingly.

@tmpfs tmpfs self-assigned this May 25, 2024
@tmpfs tmpfs pinned this issue Dec 23, 2024
@tmpfs
Copy link
Collaborator Author

tmpfs commented Dec 26, 2024

There is an issue with this that the browser extension helper needs to listen for changes to the data source and there is a bug using notify with sqlite databases on MacOS that would prevent us from keeping the browser extension UI in sync as changes are made in the app, see notify-rs/notify#613.

@tmpfs tmpfs closed this as completed Dec 26, 2024
@tmpfs tmpfs reopened this Dec 26, 2024
@tmpfs
Copy link
Collaborator Author

tmpfs commented Dec 26, 2024

The alternative approach to detect changes would be to avoid notify and use the hooks feature of rusqlite:

    conn.update_hook(Some(
        move |action: Action, db: &str, table: &str, id: i64| {
            println!("Update hook: {:#?} {} {} {}", action, db, table, id);
        },
    ));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant