Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional dependency rack used internally #229

Closed
tbolender opened this issue Dec 17, 2021 · 3 comments · Fixed by #230
Closed

Optional dependency rack used internally #229

tbolender opened this issue Dec 17, 2021 · 3 comments · Fixed by #230
Labels

Comments

@tbolender
Copy link
Contributor

tbolender commented Dec 17, 2021

Thanks for your work on this gem! We notice the following error on all non-Rails usages after the update to version 3.0.0:

/app/vendor/bundle/ruby/2.7.0/gems/httpi-3.0.0/lib/httpi/request.rb:4:in `require': cannot load such file -- rack/utils (LoadError)
	from /app/vendor/bundle/ruby/2.7.0/gems/httpi-3.0.0/lib/httpi/request.rb:4:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.7.0/gems/httpi-3.0.0/lib/httpi.rb:4:in `require'
	from /app/vendor/bundle/ruby/2.7.0/gems/httpi-3.0.0/lib/httpi.rb:4:in `<top (required)>'

I noticed that you made rack an optional dependency, but seem to treat it internally as mandatory. I would be glad to have the reference either removed or as an actual dependency set (that it seems to be?).

@olleolleolle
Copy link
Contributor

Yeah, the smoothest way would probably be to upgrade it to be a... real runtime dependency: https://github.com/savonrb/httpi/search?q=Utils

HeaderHash class and something about building URLs.

@olleolleolle
Copy link
Contributor

@tbolender Would you like to offer a PR adding rack as a runtime dependency in the gemspec?

@tbolender
Copy link
Contributor Author

Here you go. Would be nice to have that as soon as possible out there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants