Significant perfomance improvement for very large responses #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working with a webservice that returns really large responses (some over 5mb) and after switching from Savon 0.7.9 to 0.8 these took a very long time to process (not sure how long, didn't want to wait for over an hour.)
Turns out this is caused by the regex that checks for a soap fault element. This commit changes the check so that the regex only checks the first 1000 chars of the response string. It should work properly in most (if not all) cases; the tests still pass and the soap fault fixtures range in size from 270 to 672 chars.