Hook should not replace request

[kalarani]

Right now the Savon::Hooks::Hook replaces the POST request executed to call a service. Ideally I would expect a hook to be called before/after/around the service call, not to replace the service call itself.

I can return false from my hook and let the Savon::SOAP::Request class make the request by itself. But that'll be useful only if I'm interested in doing some stuff before the call.

Hooks should be improvised to let user hook into events like 'before_request', 'after_request' etc.,

[kalarani]

Have explained the issue with hooks here, where I'm trying to measure time taken by each soap request.

Since Savon::Hooks::Hook replaces the request, I have to place the request from the hook itself, though I'm just interested in hooks just before the call is placed and after the response is received.

[rubiii]

could you test whether this change works for you? there's a spec describing your use case.
basically you should be able to replace your code with:

Savon.configure do |c|
  c.hooks.define('new_hook', :soap_request) do |callback, req|
    start_time = Time.now
    response = callback.call
    SavonInstrument.add req.http.headers['SoapAction'], Time.now - start_time
    response
  end
end

[kalarani]

It works!! Thank you!!

[rubiii]

you're welcome