Optional final xml element in a soap.body block

[rob-anderson]

When constructing request xml via a block like this

client.request(:wsdl, 'SomeService') do

  soap.body do |xml|
    xml.foo 'bar'
  end
end

it all works fine.

But if we want to make the final element optional, and it happens to return false, the request body will be empty:

client.request(:wsdl, 'SomeService') do

  soap.body do |xml|
    xml.foo 'bar'
    xml.baz 'bat' if some_test # which evaluates to false
  end
end

This is because savon relies on the return value of the last statement in the block to determine the xml string. I think this is a bug as it produces problems in the scenario above.

The only way round it afaik is clunky code like this:

client.request(:wsdl, 'SomeService') do

  soap.body do |xml|
    xml.foo 'bar'
    if some_test
      xml.baz 'bat'
    else
      xml.target!
    end
  end
end

Should savon not be relying on the modified state of the xml object after the yield, rather than the value returned from the block?

[rubiii]

thanks for reporting. i'll look into it.

[rob-anderson]

Wow, that was quick. Thanks!

[rubiii]

a quick fix, but since this is not a regression, you still have to wait for the next release ;)