Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

story(sbb-teaser-hero): refactor for multiple use cases #2949

Closed
9 tasks
kyubisation opened this issue Jul 22, 2024 · 0 comments · Fixed by #2984
Closed
9 tasks

story(sbb-teaser-hero): refactor for multiple use cases #2949

kyubisation opened this issue Jul 22, 2024 · 0 comments · Fixed by #2984
Assignees
@MarioCastigliano
Labels
complexity: S Can be done in about a day proposal: accepted

Comments

@kyubisation
Copy link
Contributor

kyubisation commented Jul 22, 2024 •
edited
Loading

Feature Description

We want to refactor the sbb-teaser-hero (and in turn remove sbb-teaser-paid) for the new requirements from #2602.

  • The teaser hero should additionally support chips (as is currently done in sbb-teaser-paid with a slot).
  • If no unnamed slot content is slotted and the link-content property and slot is not used, the red panel should not be displayed.
  • Move sbb-teaser-hero into the main package.
  • Delete sbb-teaser-paid

Closes #2602

Definition of Done

  • Component is refactored
  • Documentation is updated
  • Tests are implemented
  • Storybook stories are implemented
  • Navigation via keyboard is tested
  • Screen reader output is tested
  • High-contrast is tested
  • Remaining accessibility is tested
  • UX approved
@kyubisation kyubisation moved this from Funnel to Next in ESTA Web Lyne Design System Jul 22, 2024
@kyubisation kyubisation added proposal: accepted complexity: S Can be done in about a day and removed proposal: open labels Jul 22, 2024
@MarioCastigliano MarioCastigliano self-assigned this Jul 22, 2024
@TomMenga TomMenga moved this from Next to In progress in ESTA Web Lyne Design System Jul 24, 2024
@MarioCastigliano MarioCastigliano mentioned this issue Aug 2, 2024
Merged
28 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in ESTA Web Lyne Design System Aug 8, 2024
@jeripeierSBB jeripeierSBB mentioned this issue Aug 8, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarioCastigliano MarioCastigliano

Labels
complexity: S Can be done in about a day proposal: accepted
Projects
ESTA Web Lyne Design System
Archived in project
Milestone
No milestone
2 participants
@kyubisation @MarioCastigliano