Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: didClose and willClose fires also on sbb-dialog when closing a sbb-autocomplete #3273

Closed
3 tasks done
stefan-schubert-sbb opened this issue Dec 5, 2024 · 0 comments · Fixed by #3278
Closed
3 tasks done

[Bug]: didClose and willClose fires also on sbb-dialog when closing a sbb-autocomplete #3273

stefan-schubert-sbb opened this issue Dec 5, 2024 · 0 comments · Fixed by #3278
Assignees
@jeripeierSBB
Labels
type: bug 🐛 Something isn't working

Comments

@stefan-schubert-sbb
Copy link

Preflight Checklist

Bug type

Functionality

It affects the following packages

Components

Which version of Lyne Components are you using

No response

Operating system

No response

Browser / Browser version

No response

Input mode

None

Additional settings

No response

What happened?

sbb-dialog events didClose and willClose also fired if sbb-autocomplete used in the dialog closes. Maybe event bubbling is not stopped?

Steps to reproduce the issue

  1. use sbb-autocomplete in sbb-dialog
  2. close sbb-autocomplete drop-down
  3. didClose and willClose are fired on sbb-dialog

Relevant log output

No response
@stefan-schubert-sbb stefan-schubert-sbb added the type: bug 🐛 Something isn't working label Dec 5, 2024
@jeripeierSBB jeripeierSBB moved this from Funnel to Next in ESTA Web Lyne Design System Dec 5, 2024
@jeripeierSBB jeripeierSBB moved this from Next to Funnel in ESTA Web Lyne Design System Dec 5, 2024
@jeripeierSBB jeripeierSBB self-assigned this Dec 5, 2024
@jeripeierSBB jeripeierSBB moved this from Funnel to In progress in ESTA Web Lyne Design System Dec 5, 2024
@jeripeierSBB jeripeierSBB mentioned this issue Dec 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in ESTA Web Lyne Design System Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeripeierSBB jeripeierSBB

Labels
type: bug 🐛 Something isn't working
Projects
ESTA Web Lyne Design System
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: opening and close events no longer bubble sbb-design-systems/lyne-components
2 participants
@jeripeierSBB @stefan-schubert-sbb