feat(business/header): implement header component #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianluca-r
force-pushed
the
feature/business-header
branch
2 times, most recently
from
647c30b to
147e884
Compare
gianluca-r
changed the title
gianluca-r
force-pushed
the
feature/business-header
branch
from
147e884 to
2484423
Compare
kyubisation
requested changes
Aug 29, 2019
projects/angular-showcase/src/app/examples/header-showcase/header-showcase.component.ts
Outdated
Show resolved
Hide resolved
projects/angular-showcase/src/app/examples/header-showcase/header-showcase.component.ts
Outdated
Show resolved
Hide resolved
projects/sbb-esta/angular-business/src/lib/header/styles/_header.scss
Outdated
Show resolved
Hide resolved
projects/sbb-esta/angular-business/src/lib/header/styles/_header.scss
Outdated
Show resolved
Hide resolved
projects/sbb-esta/angular-business/src/lib/header/header/header.component.ts
Show resolved
Hide resolved
projects/sbb-esta/angular-business/src/lib/header/styles/_navButton.scss
Outdated
Show resolved
Hide resolved
projects/sbb-esta/angular-business/src/lib/header/navbutton/navbutton.component.ts
Outdated
Show resolved
Hide resolved
projects/sbb-esta/angular-business/src/lib/header/navbutton/navbutton.component.ts
Outdated
Show resolved
Hide resolved
projects/sbb-esta/angular-public/src/lib/dropdown/dropdown-trigger.directive.ts
Outdated
Show resolved
Hide resolved
kyubisation
requested changes
Sep 3, 2019
projects/sbb-esta/angular-business/src/lib/header/navbutton/navbutton.component.ts
Outdated
Show resolved
Hide resolved
projects/angular-showcase/src/app/examples/header-showcase/header-showcase.component.html
Outdated
Show resolved
Hide resolved
projects/sbb-esta/angular-business/src/lib/header/header/header.component.ts
Show resolved
Hide resolved
projects/sbb-esta/angular-business/src/lib/header/navbutton/navbutton.component.ts
Show resolved
Hide resolved
projects/sbb-esta/angular-business/src/lib/header/navbutton/navbutton.component.ts
Show resolved
Hide resolved
added 4 commits
September 4, 2019 12:57
- Cleaned code - Removed MutationObservers - Removed extra markup files - Refactored sbb-navbutton to button[sbbNavbutton]
- Merged css for header components to allow <a> tags to keep button styling
gianluca-r
force-pushed
the
feature/business-header
branch
from
4959258 to
9e0f990
Compare
kyubisation
requested changes
Sep 4, 2019
projects/angular-showcase/src/app/public/examples/examples.module.ts
Outdated
Show resolved
Hide resolved
gianluca-r
force-pushed
the
feature/business-header
branch
from
53df19b to
64c360e
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to dropdown-trigger were made to allow it to automatically resize when the host component changes it's width, if no panelWidth is set, otherwise it wouldn't register and stay the old size inside the header.
Closes (#93).