feat(autocomplete): implement autocomplete hint #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 10, 2019 12:13
marcodev01
changed the title
kyubisation
requested changes
Sep 10, 2019
...-showcase/src/app/public/examples/autocomplete-showcase/autocomplete-showcase.component.html
Outdated
Show resolved
Hide resolved
...-showcase/src/app/public/examples/autocomplete-showcase/autocomplete-showcase.component.html
Outdated
Show resolved
Hide resolved
...ar-showcase/src/app/public/examples/autocomplete-showcase/autocomplete-showcase.component.ts
Outdated
Show resolved
Hide resolved
.../sbb-esta/angular-public/autocomplete/src/autocomplete-hint/autocomplete-hint.component.html
Outdated
Show resolved
Hide resolved
...ts/sbb-esta/angular-public/autocomplete/src/autocomplete-hint/autocomplete-hint.component.ts
Outdated
Show resolved
Hide resolved
...ts/sbb-esta/angular-public/autocomplete/src/autocomplete-hint/autocomplete-hint.component.ts
Show resolved
Hide resolved
...ts/sbb-esta/angular-public/autocomplete/src/autocomplete-hint/autocomplete-hint.component.ts
Outdated
Show resolved
Hide resolved
refactoring according pr review #154
|
Thanks for your review and input 😃 |
kyubisation
approved these changes
Sep 11, 2019
|
LGTM 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocomplete options list can be enhanced with additional text.
New feature implementation according #154