Feature/business dialog #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2019 13:26
Implement dialog component, create dialog examples and documentation
…n/sbb-angular into feature/business-dialog
kyubisation
requested changes
Oct 24, 2019
projects/sbb-esta/angular-business/dialog/src/dialog/dialog-content.ts
Outdated
Show resolved
Hide resolved
projects/sbb-esta/angular-business/dialog/src/dialog/dialog-container.component.scss
Outdated
Show resolved
Hide resolved
projects/sbb-esta/angular-business/dialog/src/dialog/dialog-content.ts
Outdated
Show resolved
Hide resolved
added 8 commits
October 28, 2019 08:39
Improve showcase text
Fix layering for dialog component
Improve imports on dialog styling
Improve documentation
Remove double declaration
Add background opacity
Extract components and directives into separate files
Add positioning and size configuration, separate styles to components
samlanzz
commented
Nov 4, 2019
There was a problem hiding this comment.
There are still some issues with this component, I'm slowly working through them. My main concerns at the moment:
- initial dialog size
- content not scrolling when size is set by hand
- ugly & > * selector in dialog-container.component.scss
Any input is appreciated!
|
I'll have a look at the changes. |
Improve default size and scroll overflow of content
kyubisation
requested changes
Nov 11, 2019
...s/sbb-esta/angular-business/dialog/src/dialog/dialog-container/dialog-container.component.ts
Show resolved
Hide resolved
projects/sbb-esta/angular-business/dialog/src/dialog/dialog-footer/dialog-footer.component.ts
Outdated
Show resolved
Hide resolved
Improve example description
kyubisation
reviewed
Nov 11, 2019
...sbb-esta/angular-business/dialog/src/dialog/dialog-container/dialog-container.component.scss
Outdated
Show resolved
Hide resolved
added 5 commits
November 11, 2019 09:23
Set default dialog max-height
Remove unnecessary initial focus
Remove perfect scrollbar from dialog footer
Refactor styles to reside inside component structure
Remove unnecessary styles and directive for dialog title
kyubisation
approved these changes
Nov 11, 2019
|
LGTM 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(business): dialog
Add a dialog component for the business scope.
NOTE: there are still overflow issues for the dialog body.