-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(business): implement tabs #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution 😃
Looks very good already. I've requested some changes.
...src/app/business/business-examples/tabs-showcase/person/person-list/person-list.component.ts
Outdated
Show resolved
Hide resolved
...ular-showcase/src/app/features/business-component-viewer/business-component-viewer.module.ts
Show resolved
Hide resolved
@Frenggi Can you have a look at https://angular-staging.app.sbb.ch/210/business/components/tabs |
Hi @kyubisation I'm aware, that this design is a bit trickier to implement in a component than the one for tabs in public library. Therefore we might have to discuss what possibilities we have as a compromise between design and the implemented component. |
@Frenggi Thanks for the hint. I confused inactive with disabled. Could you update https://designsystems.app.sbb.ch/en/webapps/components/tab and add a spec for disabled tabs? |
@kyubisation Is the build pipeline currently broken? |
I switched from travis-ci to github actions, however there was a problem with the scripts name, which I fixed just now. You can rebase on master and then it should work. |
@kyubisation Any update? We'd appreciate it if we could use the tabs in our projects soon... |
@uzysset Please rebase the PR on top of master and force push the changes. We will merge it as it currently is and open another issue for adaptation to the new design spec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
Thank you very much!
Closes #87