feat(business/button): expose button component for business #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efux
changed the title
…tton # Conflicts: # projects/sbb-esta/angular-business/src/public-api.ts
kyubisation
reviewed
Jun 20, 2019
projects/sbb-esta/angular-business/src/lib/button/button/button.component.ts
Outdated
Show resolved
Hide resolved
|
@efux LGTM. Thanks for your work. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the
buttoncomponent for business applications.Styling should be according to the digital guidelines of SBB for business applications.
The
buttoncomponent of the public package has the following modes:primarysecondaryghostframelessThe
buttoncomponent from the business package allows other modes:primaryalternativeghosticonWhich should only contain one icon with the*sbbButtonIcondirective.Business buttons also support icons along with text with the normal modes
primary,alternative,ghost, even though this use case was not specifically mentioned in the style guide. However the animations on hover were removed. On hover the background color of the buttons changes the same as without icon.