Skip to content

Commit 3a8e30c

Browse files
committed
Bump min supported node version from 10.19 to 12.20
This is the minimum node version that we support targeting. Bumping to v12.20 specifically allows us to start using `node:xx` for imports. See emscripten-core#18235 Fixes: emscripten-core#23652
1 parent 9c9b3f7 commit 3a8e30c

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

.circleci/config.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -774,10 +774,10 @@ jobs:
774774
# support in the generated code.
775775
# Keep this in sync with `OLDEST_SUPPORTED_NODE` in `feature_matrix.py`
776776
- install-node-version:
777-
node_version: "10.19.0"
777+
node_version: "12.20.0"
778778
- run-tests:
779-
title: "node (oldest / 10.19.0)"
780-
extra-cflags: "-sMIN_NODE_VERSION=101900"
779+
title: "node (oldest / 12.20.0)"
780+
extra-cflags: "-sMIN_NODE_VERSION=122000"
781781
# We include most but not all of the nodefs and node rawfs tests here.
782782
# test_fs_nodefs_rw, test_fs_nodefs_statvfs, and test_unistd_io_nodefs_bigint fail.
783783
test_targets: "

site/source/docs/tools_reference/settings_reference.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2955,7 +2955,7 @@ Specifies minimum node version to target for the generated code. This is
29552955
distinct from the minimum version required run the emscripten compiler.
29562956
This version aligns with the current Ubuuntu TLS 20.04 (Focal).
29572957
Version is encoded in MMmmVV, e.g. 181401 denotes Node 18.14.01.
2958-
Minimum supported value is 101900, which was released 2020-02-05 (see
2958+
Minimum supported value is 122000, which was released 2020-11-25 (see
29592959
feature_matrix.py).
29602960

29612961
Default value: 160000

src/settings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1929,7 +1929,7 @@ var MIN_CHROME_VERSION = 85;
19291929
// distinct from the minimum version required run the emscripten compiler.
19301930
// This version aligns with the current Ubuuntu TLS 20.04 (Focal).
19311931
// Version is encoded in MMmmVV, e.g. 181401 denotes Node 18.14.01.
1932-
// Minimum supported value is 101900, which was released 2020-02-05 (see
1932+
// Minimum supported value is 122000, which was released 2020-11-25 (see
19331933
// feature_matrix.py).
19341934
var MIN_NODE_VERSION = 160000;
19351935

test/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1188,7 +1188,7 @@ def setUp(self):
11881188
nodejs = self.get_nodejs()
11891189
if nodejs:
11901190
node_version = shared.get_node_version(nodejs)
1191-
if node_version < (11, 0, 0):
1191+
if node_version < (13, 1, 0):
11921192
self.node_args.append('--unhandled-rejections=strict')
11931193
self.node_args.append('--experimental-wasm-se')
11941194
else:

tools/feature_matrix.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,8 @@
2121
OLDEST_SUPPORTED_CHROME = 45 # September 1, 2015
2222
OLDEST_SUPPORTED_FIREFOX = 40 # August 11, 2015
2323
OLDEST_SUPPORTED_SAFARI = 101000 # September 20, 2016
24-
# 10.19.0 is the oldest version of node that we do any testing with.
2524
# Keep this in sync with the test-node-compat in .circleci/config.yml.
26-
OLDEST_SUPPORTED_NODE = 101900
25+
OLDEST_SUPPORTED_NODE = 122000
2726

2827

2928
class Feature(IntEnum):

0 commit comments

Comments
 (0)