Move _emval_coro_resume to bind.cpp (emscripten-core#20681)

Author: RReverser

system/include/emscripten/val.h

@@ -705,14 +705,6 @@ class val_awaiter {
   // of the `co_await ...` expression - in our case, the stored value.
   val await_resume() { return std::move(std::get<STATE_RESULT>(state)); }
 };
-
-extern "C" {
-  // JS FFI helper for `val_awaiter::resume_with`.
-  __attribute__((weak))
-  void _emval_coro_resume(val_awaiter* awaiter, EM_VAL result) {
-    awaiter->resume_with(val::take_ownership(result));
-  }
-}
 }
 
 // `promise_type` is a well-known subtype with well-known method names

system/lib/embind/bind.cpp

@@ -63,6 +63,10 @@ void _embind_register_bindings(InitFunc* f) {
   init_funcs = f;
 }
 
+void _emval_coro_resume(val_awaiter* awaiter, EM_VAL result) {
+  awaiter->resume_with(val::take_ownership(result));
+}
+
 }
 
 namespace {

test/code_size/embind_val_wasm.json

@@ -3,8 +3,8 @@
   "a.html.gz": 431,
   "a.js": 7498,
   "a.js.gz": 3142,
-  "a.wasm": 9628,
-  "a.wasm.gz": 4938,
-  "total": 17799,
-  "total_gz": 8511
+  "a.wasm": 11450,
+  "a.wasm.gz": 5732,
+  "total": 19621,
+  "total_gz": 9305
 }

test/test_other.py

@@ -9053,6 +9053,7 @@ def test(check, extra):
     'gl_emu': (['-sLEGACY_GL_EMULATION', '-sMAXIMUM_MEMORY=4GB', '-sALLOW_MEMORY_GROWTH'],),
     'no_exception_throwing': (['-sDISABLE_EXCEPTION_THROWING'],),
     'minimal_runtime': (['-sMINIMAL_RUNTIME'],),
+    'embind': (['-lembind'],),
   })
   def test_full_js_library(self, args):
     self.run_process([EMCC, test_file('hello_world.c'), '-sSTRICT_JS', '-sINCLUDE_FULL_LIBRARY'] + args)

tools/system_libs.py

@@ -1808,6 +1808,7 @@ def __init__(self, **kwargs):
 
   def get_cflags(self):
     cflags = super().get_cflags()
+    cflags.append('-std=c++20')
     if not self.with_rtti:
       cflags += ['-fno-rtti', '-DEMSCRIPTEN_HAS_UNBOUND_TYPE_NAMES=0']
     return cflags