Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCMCPosterior not pickable after vectorized slice sampling #1278

Closed
manuelgloeckler opened this issue Sep 14, 2024 · 0 comments · Fixed by #1291
Closed

MCMCPosterior not pickable after vectorized slice sampling #1278

manuelgloeckler opened this issue Sep 14, 2024 · 0 comments · Fixed by #1291
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@manuelgloeckler
Copy link
Contributor

Describe the bug
The new support for batched sampling introduced a local function multi_obs_potential. This will be cached as posterior sampler in self making it not saveable using pickle.

Expected behavior
Should be saveable as the rest of the posteriors.

Possible fixes:

  • overwrite get_state and set self.posterior._posterior_sampler = None (remove cached object)
  • not using local functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pickle issues in MCMC posterior + test sbi-dev/sbi
1 participant
@manuelgloeckler