New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move `.map()` and `.sample_conditional()` to `sbi.analysis`? #574

Closed

michaeldeistler opened this issue Jan 5, 2022 · 0 comments · Fixed by #573

Labels

Contributor

michaeldeistler commented Jan 5, 2022 •

edited

Loading

Current API:

map_ = posterior.map()
samples = posterior.sample_conditional(...)

Suggested change:

from sbi.analysis import optimize, sample_conditional

map_ = optimize(posterior)
samples = sample_conditional(posterior, ...)

This would have the benefit of having minimal posterior classes which would make things easier to maintain.

jan-matthis linked a pull request

that will close this issue

Sampler interface #573

Merged

jan-matthis added the API changes label

michaeldeistler closed this as completed in #573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment