Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distinguish map and map_ #578

Closed
michaeldeistler opened this issue Jan 12, 2022 · 1 comment · Fixed by #633
Closed

distinguish map and map_ #578

michaeldeistler opened this issue Jan 12, 2022 · 1 comment · Fixed by #633
Assignees
@janfb
Labels
good first issue Good for newcomers hackathon

Comments

@michaeldeistler
Copy link
Contributor

@janfb wrote on #573 : having map(...) and map_ could be confusing. how about making map a lazy property of the posterior that is calculated on demand and then saved.
@michaeldeistler michaeldeistler mentioned this issue Jan 12, 2022
Merged
@janfb janfb self-assigned this Jan 12, 2022
@janfb janfb added good first issue Good for newcomers hackathon labels Jan 20, 2022
@gmoss13
Copy link
Contributor

gmoss13 commented Jan 28, 2022

I'm not sure properties would work here, because they don't take arguments, and we might want to calculate a new MAP (e.g. for a different observation). Maybe we should just rename to have a calculate_map() method and a map property, or something along those lines?

@gmoss13 gmoss13 linked a pull request Feb 2, 2022 that will close this issue
MAP property for posteriors #633
Merged
@janfb janfb closed this as completed in #633 Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janfb janfb

Labels
good first issue Good for newcomers hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAP property for posteriors sbi-dev/sbi
3 participants
@janfb @michaeldeistler @gmoss13