Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt release workflow in wiki to pyproject.toml setup. #940

Closed
janfb opened this issue Feb 14, 2024 · 2 comments · Fixed by #941
Closed

Adapt release workflow in wiki to pyproject.toml setup. #940

janfb opened this issue Feb 14, 2024 · 2 comments · Fixed by #941
Assignees
@janfb
Labels
documentation Improvements or additions to documentation less-urgent This is beyond the current 2 week horizon
Milestone
Sustainable archi...

Comments

@janfb
Copy link
Contributor

janfb commented Feb 14, 2024

once #928 is fixed, we need to test making a new release using only the git tag as version reference (details here: https://carpentries-incubator.github.io/python_packaging/instructor/05-publishing.html#extra-consistent-versioning-with-setuptools-scm)
@janfb janfb added the documentation Improvements or additions to documentation label Feb 14, 2024
@janfb janfb added this to the Pre Hackathon 2024 milestone Feb 14, 2024
@janfb janfb self-assigned this Feb 14, 2024
@janfb janfb mentioned this issue Feb 14, 2024
Merged
@janfb janfb reopened this Feb 16, 2024
@janfb janfb added the less-urgent This is beyond the current 2 week horizon label Apr 3, 2024
@janfb
Copy link
Contributor Author

janfb commented Jul 22, 2024

We will automate the release workflow in #1147, e.g., add a GitHub action that prepares the notebooks for the website docs.
I suggest to not automate the release workflow and versioning for now.

@janfb
Copy link
Contributor Author

janfb commented Aug 6, 2024

closing this because we will keep doing the versioning manually.

@janfb janfb closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janfb janfb

Labels
documentation Improvements or additions to documentation less-urgent This is beyond the current 2 week horizon
Projects
None yet
Milestone
Sustainable architecture
Development

Successfully merging a pull request may close this issue.

replace setup.py with pyproject.toml workflow sbi-dev/sbi
1 participant
@janfb