Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt SNRE to new DensityEstimator abstraction #992

Closed
gmoss13 opened this issue Mar 13, 2024 · 5 comments
Closed

Adapt SNRE to new DensityEstimator abstraction #992

gmoss13 opened this issue Mar 13, 2024 · 5 comments
Assignees
Labels
architecture Internal changes without API consequences enhancement New feature or request hackathon

Comments

@gmoss13
Copy link
Contributor

gmoss13 commented Mar 13, 2024

It would be good to create a RatioEstimator to use for SNRE methods, similar to DensityEstimator abstraction already implemented. The API and broadcasting should be similar, so possibly this should be handled in a parent Estimator class (see #966)

@gmoss13 gmoss13 added the enhancement New feature or request label Mar 13, 2024
@gmoss13 gmoss13 changed the title Adapt MNLE to new DensityEstimator abstraction Adapt SNRE to new DensityEstimator abstraction Mar 13, 2024
@gmoss13 gmoss13 added architecture Internal changes without API consequences hackathon labels Mar 13, 2024
@bkmi bkmi self-assigned this Mar 18, 2024
@bkmi
Copy link
Contributor

bkmi commented Mar 18, 2024

I will take a look at this and formulate some ideas.

@bkmi
Copy link
Contributor

bkmi commented Mar 19, 2024

The purpose of the layer is to:

  1. compute the loss
  2. wrap the ratio estimate (for example for weighing it)
  3. embedding functions for both theta and x (subsuming StandardizeInputs StandardizeInputs requires a list of exactly two elements #1036)
  4. provide a function to combine embed_theta(theta) and embed_x(x) into a single tensor.

Non-goals:

  • introduce methods to approximate ratios of normalized distributions as in torch-mist here

Progress:

  • Change classifier_nn helper function to return new Ratio Estimator Class
  • Integrate new interface into SNRE base classes.

@bkmi
Copy link
Contributor

bkmi commented Mar 19, 2024

Note: this will address the ratio aspect of #957 .

@bkmi
Copy link
Contributor

bkmi commented Mar 20, 2024

this is being updated to reflect the goals of #1041 and #1046

@janfb
Copy link
Contributor

janfb commented Jul 9, 2024

solved with #1097

@janfb janfb closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Internal changes without API consequences enhancement New feature or request hackathon
Projects
None yet
Development

No branches or pull requests

3 participants