-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deb package dependencies #1106
Comments
Thanks for your report 😀 We haven't set any defaults, because there is no good one IMHO. Packages and versions can vary in a wide range. This would mean we would break a lot of packages just by wrong defaults. You can add dependencies if you like, but you don't have to. |
Could you provide an example of what could break exactly? As far as I see, all Debian/Ubuntu repositories supply multiple JRE packages, but due to convention, all of them provide The only concern I've found is that there are two "flavours" — I understand that it's important to not break existing user's installations, but may be we could at least recommend adding |
Sorry for my short reply 😀 Didn't meant to be round.
I can't. My concern comes from having no insights on how people configure their Debian packages. We have had a lot of interesting configurations. For example some users try to ship their application along with an JRE, so this dependency would not be necessary. Where would we add the JRE dependency? the
That would be awesome 🤩 Would you like to open a pull request for this? |
Well, if you'd ask me, I'd say that if user does not want to integrate into Debian/Ubuntu packaging environment (and would instead install JRE somehow manually), there is no point to use .deb packages in the first place. However, given that a app's owner needs to decide which JRE variant one requires (full or headless), there's still some manual work needed to specify that => probably a documentation template / recommendation solution would work the best.
Will do, hang on! |
I fully agree with you, but I have seen too many weird stuff, a lot of newcomers that struggle with the complexity of their build/deploy or company restrictions that make basic things non-trivial. Setting defaults, means maintaining them, and for a small open source project like sbt-native-packer the cost is often higher. Thank you for taking the time to discuss this and helping to improve the sbt-native-packer documentation 😍 |
Submitted my attempt at documenting the situation as #1107 — please take a look? |
Thanks for accepting! I believe that this issue is resolved then. |
Thanks for your time to add this 🤩 |
It caught my attention that .deb packages which sbt-native-packager generates lacks any dependencies, even on the JRE (i.e. something like
default-jre
or may be even something that states minimal version needed, as, for example, nowadays Scala-build .class files require Java >=8 due to 52.0 class version).Expected behaviour
apt-get install my-package
installs all required stuff to makemy-package
build by sbt-native-packager work on Debian/Ubuntu.Actual behaviour
Package installs, but trying to run it yields
Information
rpm --version
):The text was updated successfully, but these errors were encountered: