Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: application.ini is not used with ash #1162

Closed
yanns opened this issue Sep 26, 2018 · 4 comments
Closed

docker: application.ini is not used with ash #1162

yanns opened this issue Sep 26, 2018 · 4 comments

Comments

@yanns
Copy link
Contributor

yanns commented Sep 26, 2018

When publishing a docker container with ash (enablePlugins(AshScriptPlugin, DockerPlugin)), the file application.ini is not used.

The docker run outputs the following error:

sed: -e expression #1, char 2: unknown command: `/'

This should be coming from the application launcher script:

# Loads a configuration file full of default command line options for this script.
loadConfigFile() {
  cat "$1" | sed $'/^\#/d;s/\r$//' | sed 's/^-J-X/-X/' | tr '\r\n' ' '
}
@yanns
Copy link
Contributor Author

yanns commented Sep 26, 2018

The docker container is still starting.
A better way would be to fail starting in case of such errors to avoid starting the application with a wrong configuration.

@yanns
Copy link
Contributor Author

yanns commented Sep 26, 2018

Removing the $ fixes the problem:

loadConfigFile() {
  cat "$1" | sed '/^\#/d;s/\r$//' | sed 's/^-J-X/-X/' | tr '\r\n' ' '
}

PR will follow.

@yanns
Copy link
Contributor Author

yanns commented Sep 26, 2018

duplicated of #1154.
Already fixed.

@yanns yanns closed this as completed Sep 26, 2018
@muuki88
Copy link
Contributor

muuki88 commented Sep 26, 2018

Thanks for offering a PR even if not necessary anymore 🤗😘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants