Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted JlinkPlugin improvements #1240

Closed
nigredo-tori opened this issue Jun 20, 2019 · 1 comment · Fixed by #1242
Closed

Assorted JlinkPlugin improvements #1240

nigredo-tori opened this issue Jun 20, 2019 · 1 comment · Fixed by #1242

Comments

@nigredo-tori
Copy link
Collaborator

nigredo-tori commented Jun 20, 2019

I finally got around to using JlinkPlugin in my work projects, and there are some things that need work. I'll probably do these myself soon-ish, so this issue is just for documentation.

  1. We need more flexible constructors in Ignore. I'm thinking some simple string globbing.
  2. Our jlink call should include our classpath in --module-path, since there might be modular JARs there, and these are caught by our jdeps output parser.
  3. If we have no explicit javaHome we use java from PATH, which is not necessarily the JVM in which SBT is running. We should use java.home system property instead.
@muuki88
Copy link
Contributor

muuki88 commented Jun 21, 2019

Thanks for opening an issue for this @nigredo-tori 😍
I'm happy to merge any pull requests you send 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants