Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate entries in zip #25

Closed
jroper opened this issue Sep 2, 2013 · 3 comments
Closed

Duplicate entries in zip #25

jroper opened this issue Sep 2, 2013 · 3 comments

Comments

@jroper
Copy link
Member

jroper commented Sep 2, 2013

The scriptClasspathOrdering config in JavaAppPackaging.settings adds the projects binary to the config, regardless of whether it's already there or not. The comment there suggests that there is a reason for this. That's ok, but the result is that for zip packaging for example, you end up with the binary packaged twice, and then when you unzip, the Linux unzip command stops on the second entry and prompts you to ask whether you want to overwrite it or not. Either the scriptClasspathOrdering should be fixed, or when it's added to mappings, distinct needs to be called on it.

@huntc
Copy link
Contributor

huntc commented Sep 2, 2013

Associated PR: #26

@benmccann
Copy link
Contributor

Looks like this issue is fixed now and can be closed. #26

@jsuereth
Copy link
Member

jsuereth commented Sep 3, 2013

Thanks @benmccann and @huntc

@jsuereth jsuereth closed this as completed Sep 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants