-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't combine PlayJava with JDebPackaging plugin #407
Comments
Thanks a lot for the detailed bug report. @kardapoltsev already fixed some issues regarding jdeb. |
I'm not very familiar with autoplugins but could you try to enable Play plugin first and then jdeb? |
This shouldn't change anything. One of the main reasons for auto plugins was the fixing these ordering issues. |
Yep, sorry I forgot to mention, I had tried changing the ordering, this had no effect as mentioned above. |
Okay, I can reproduce your error and this is very spurious. @huntc do you now more about this? I assume this is in Project.scala packageArchetype.java_server ++ overrides everything you love. |
Sorry - no idea. Here are the settings I use for a Play project though: huntc/angular-seed-play-1@typesafehub:master...sbt-native-packager-upgrade (you can now use the M2 milestone instead of that version I have) |
Wouldn't JavaAppPackaging invoke the built-in non-cross-platform .deb packaging tool, rather than JDeb? |
@jsuereth looks like you added a line we have a question about in playframework/playframework@f64336d. Do you know more about it? Sounds like from the commit comment that it was maybe meant to be temporary? @muuki88 Note that we also do a bunch of native packager setup in PlaySettings.scala |
I tried M3, and re-ran the steps in my bug report. It seems to have generated a .deb file, so that's good. I will try this on a real project this evening/soon, (check the file is valid and works on ubuntu), and update this issue. |
Nice :) Thanks for reporting back |
Ah sorry, I had it pointing to the wrong project version (the one without the PlayJava plugin). |
I filed a bug to track this in Play since it sounds like that's where the issue is playframework/playframework#3801 |
If you try this with Play 2.4 (which you would need to build from source) it should hopefully be fixed now |
Ok, thanks for the update, I'll try to give this a go this weekend. |
I've tried out the latest, and I still seem to encounter an error, doesn't seem to be related to chmod, however there was an issue with the error below . I've updated the sample project and the error received, let me know if the setup I've used is not longer valid for play 2.4 "[error] java.lang.UnsupportedClassVersionError: play/runsupport/classloader/Appl |
What Java version are you using? |
[error] java.lang.UnsupportedClassVersionError: play/runsupport/classloader/Appl D:\workspace\play-java>java -version looks like 1.8 unless the project has some setting which determines the version to be used. |
Adding detailed stack trace
|
Hmm, yeah, definitely sounds like you're not using Java 8 though your output of |
You're right. Deleting the 7 installation, revealed JAVA_HOME was pointing to 7. Pointed it to 8 now. [error] java.lang.NoSuchMethodError: play.PlayImport$PlayKeys$.playWatchService( Tried cleaning out target folder. |
|
Ah, sorry, sneaky reference to old version of play hidden in "play-fork-run.sbt". Thanks so much for all your efforts on this @benmccann @muuki88 @huntc |
@danielburrell we have to say thanks as well for giving us valuable feedback and testing bleeding edge tech :) |
Whilst trying out 1.0.0-M2 release which fixes the JDebpackaging plugin issues seen on windows relating to chmod, I have since tried to combine the plugin in a real PlayJava project and found issues with chmod again. I have recreated the issue in the minimal project below which only occurs when you add the PlayJava plugin.
Obviously something looks broken here, question is, given it only occurs when the PlayJava plugin is enabled, does this issue sit with play, or sbt-native-packager?
I note that 0.7.4 sbt-native-packager (used by play) is evicted in favour of 1.0.0-M2 so I would expect any behaviour to be coming from sbt-native-packager.
Console output, and before/after states of build.sbt
https://gist.github.com/danielburrell/be18534a01f55fb9c426
Demo Project: https://github.com/danielburrell/jdebtest.git
The text was updated successfully, but these errors were encountered: