Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows bat does not return exit code 1 when java app returns non zero exit code #420

Closed
bjuric opened this issue Nov 28, 2014 · 4 comments

Comments

@bjuric
Copy link
Contributor

bjuric commented Nov 28, 2014

Hi, I'm using version 0.8.0-RC2 with packageArchetype.java_application and have found that an exit code of zero is always returned even when the java application exits with a higher value. Moving @endlocal higher up (right above the "if ERORRLEVEL .." line) corrects the issue.

@muuki88
Copy link
Contributor

muuki88 commented Nov 28, 2014

Thanks for your report. #393 fixed some problems with input parameters.
Can you provide a pull request with this fix and a regression test?

If you need any help regarding tests, feel free to ask :-)

@bjuric
Copy link
Contributor Author

bjuric commented Dec 1, 2014

Pull request submitted.
#421

@bjuric
Copy link
Contributor Author

bjuric commented Dec 1, 2014

New pull request #423 submitted to target 0.8.x branch.

@muuki88
Copy link
Contributor

muuki88 commented Dec 13, 2014

Integated into master in #440

@muuki88 muuki88 closed this as completed Dec 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants