Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image is not tagged when using dockerBuildOptions #935

Closed
dluc opened this issue Jan 29, 2017 · 1 comment
Closed

Image is not tagged when using dockerBuildOptions #935

dluc opened this issue Jan 29, 2017 · 1 comment

Comments

@dluc
Copy link

dluc commented Jan 29, 2017

When adding build options, e.g.

dockerBuildOptions := Seq("--label", "Tags=xyz")

the image produced is not tagged as usual. dockerUpdateLatest is affected too.
As a workaround I'm using:

dockerBuildOptions := Seq("--label", "Tags=xyz", "--tag", name.value + ":" + version.value, "--tag", name.value + ":latest")

If that's intended behavior, perhaps it would be useful to emit a warning during the build, telling the user that the image has not been tagged.

@dluc
Copy link
Author

dluc commented Jan 29, 2017

right after opening the issue I noticed the easy fix, dockerBuildOptions should be updated with ++= and not overwritten with :=, i.e. the correct syntax is

dockerBuildOptions ++= Seq("--label", "Tags=xyz")

@dluc dluc closed this as completed Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant