Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.0] Double dashes for sbt-launcher don't work on Darwin #5079

Closed
anilkumarmyla opened this issue Sep 14, 2019 · 1 comment
Closed

[1.3.0] Double dashes for sbt-launcher don't work on Darwin #5079

anilkumarmyla opened this issue Sep 14, 2019 · 1 comment
Labels
area/runner-script issues around sbt-the-bash-script, or bat script Bug
Milestone

Comments

@anilkumarmyla
Copy link
Contributor

steps

sbt version: 1.3.0

problem

If we pass in double dashed option --sbt-version, it doesn't work correctly
Debug info

$ sbt -debug --sbt-version 1.3.0 update
[addSbt] arg = '-debug'
[residual] arg = '--sbt-version'
[residual] arg = '1.3.0'
[residual] arg = 'update'
[residual] arg = '--sbt-version'
[residual] arg = '1.3.0'
[residual] arg = 'update'
[process_args] java_version = '12'
[sbt_options] declare -a sbt_options='()'
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
[copyRt] java9_rt = '/Users/anilkumarmyla/.sbt/0.13/java9-rt-ext-adoptopenjdk_12_0_2/rt.jar'
[addJava] arg = '-Dscala.ext.dirs=/Users/anilkumarmyla/.sbt/0.13/java9-rt-ext-adoptopenjdk_12_0_2'
# Executing command line:
java
-XX:+UseParallelGC
-Dfile.encoding=UTF-8
-Xms8192m
-Xmx8192m
-Xss4M
-XX:ReservedCodeCacheSize=512m
-XX:MaxPermSize=1024m
-Dscala.ext.dirs=/Users/anilkumarmyla/.sbt/0.13/java9-rt-ext-adoptopenjdk_12_0_2
-jar
/usr/local/Cellar/sbt/1.3.0/libexec/bin/sbt-launch.jar
-debug
--sbt-version
1.3.0
update

When passed as single dash, it works correctly by passing -Dsbt.version=1.3.0

$ sbt -debug -sbt-version 1.3.0 update
[addSbt] arg = '-debug'
[residual] arg = 'update'
[residual] arg = 'update'
[addJava] arg = '-Dsbt.version=1.3.0'
[process_args] java_version = '12'
[sbt_options] declare -a sbt_options='()'
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
[copyRt] java9_rt = '/Users/anilkumarmyla/.sbt/0.13/java9-rt-ext-adoptopenjdk_12_0_2/rt.jar'
[addJava] arg = '-Dscala.ext.dirs=/Users/anilkumarmyla/.sbt/0.13/java9-rt-ext-adoptopenjdk_12_0_2'
# Executing command line:
java
-XX:+UseParallelGC
-Dfile.encoding=UTF-8
-Xms8192m
-Xmx8192m
-Xss4M
-XX:ReservedCodeCacheSize=512m
-XX:MaxPermSize=1024m
-Dsbt.version=1.3.0
-Dscala.ext.dirs=/Users/anilkumarmyla/.sbt/0.13/java9-rt-ext-adoptopenjdk_12_0_2
-jar
/usr/local/Cellar/sbt/1.3.0/libexec/bin/sbt-launch.jar
-debug
update

expectation

Double dashed option should work correctly as advertized in sbt -help

@anilkumarmyla anilkumarmyla changed the title Double dashes for sbt-launcher don't work on Darwin [1.3.0] Double dashes for sbt-launcher don't work on Darwin Sep 14, 2019
@eed3si9n eed3si9n added the area/runner-script issues around sbt-the-bash-script, or bat script label Sep 14, 2019
@eed3si9n
Copy link
Member

Fixed in sbt/sbt-launcher-package#281

@eed3si9n eed3si9n added this to the 1.3.1 milestone Sep 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/runner-script issues around sbt-the-bash-script, or bat script Bug
Projects
None yet
Development

No branches or pull requests

2 participants