Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 by ruff 🚀 #155

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Replace flake8 by ruff 🚀 #155

merged 1 commit into from
Nov 26, 2022

Conversation

JonathanPlasse
Copy link
Collaborator

@JonathanPlasse JonathanPlasse commented Nov 16, 2022

Ruff is the new flake8 (near instant linting).
Check out the launch blog article.

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #155 (e30a95a) into master (07ddcaa) will increase coverage by 1.1%.
The diff coverage is 100.0%.

❗ Current head e30a95a differs from pull request most recent head cb9fa25. Consider uploading reports for the commit cb9fa25 to get more accurate results

@@           Coverage Diff            @@
##           master    #155     +/-   ##
========================================
+ Coverage    88.3%   89.4%   +1.1%     
========================================
  Files           7       7             
  Lines         540     552     +12     
  Branches       57     110     +53     
========================================
+ Hits          477     494     +17     
+ Misses         40      37      -3     
+ Partials       23      21      -2     
Impacted Files Coverage Δ
asyncio_mqtt/client.py 80.6% <100.0%> (+1.0%) ⬆️
asyncio_mqtt/types.py 100.0% <100.0%> (ø)
tests/test_client.py 100.0% <100.0%> (ø)
tests/test_error.py 100.0% <100.0%> (ø)
tests/conftest.py 100.0% <0.0%> (+33.3%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@frederikaalund
Copy link
Collaborator

frederikaalund commented Nov 19, 2022

I'm all for this. I've followed ruff for a while and it looks to be the next big thing for static analysis in python. :)

Personally, I'd use ruff alongside mypy, pylint, and black. That's because I care more about "static analysis coverage" than speed. It's a tradeoff between development velocity and code quality guarantees.

In any case, I vote that we go ahead and replace flake8 with ruff. 👍 There is no contest there. 😄

@JonathanPlasse JonathanPlasse merged commit 5a09db5 into empicano:master Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants