add clean_session argument

[madnadyka]

No description provided.

[frederikaalund]

Nice and clean implementation. :)

I have one request, though: Let's use None as the default value instead of True. This is also done in paho.mqtt.Client and it triggers special behaviour based on the other keyword arguments.

[madnadyka]

Yes, it will be better to use None! Thank you!

…

25 авг. 2020 г., в 13:21, Frederik Aalund ***@***.***> написал(а): @frederikaalund requested changes on this pull request. Nice and clean implementation. :) I have one request, though: Let's use None as the default value instead of True. This is also done in paho.mqtt.Client <https://github.com/eclipse/paho.mqtt.python/blob/master/src/paho/mqtt/client.py#L512> and it triggers special behaviour based on the other keyword arguments <https://github.com/eclipse/paho.mqtt.python/blob/master/src/paho/mqtt/client.py#L547>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHDYCIGBW3DGW4KEODEQ2DTSCN7CXANCNFSM4QKNRQUA>.

[frederikaalund]

Looks good to me. Thanks for the pull request. :)

Let me know if you run into other issues.