Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose paho tls_insecure_set(bool) #234

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

steersbob
Copy link
Contributor

Resolves #227

Adds the tls_insecure kwarg to Client __init__(). If set, the value is forwarded directly to the Paho tls_insecure_set() function.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #234 (36a8ce5) into main (33a9d9a) will decrease coverage by 0.4%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #234     +/-   ##
=======================================
- Coverage   84.5%   84.1%   -0.4%     
=======================================
  Files          4       4             
  Lines        466     468      +2     
  Branches      86      87      +1     
=======================================
  Hits         394     394             
- Misses        46      47      +1     
- Partials      26      27      +1     
Impacted Files Coverage Δ
aiomqtt/client.py 82.7% <0.0%> (-0.4%) ⬇️

@frederikaalund
Copy link
Collaborator

Hi Bob, thank you for opening this pull request. :)

LGTM! A good showcase of a nice and self-contained first PR. It does decrease our test coverage but I'll allow it. I'll merge this PR as is.

Thank you for your contribution to asyncio-mqtt. 👍

@frederikaalund frederikaalund merged commit a48cf37 into empicano:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure verification of the server hostname in the server certificate
2 participants